Automating the generation of type stubs#1142
Merged
Joao-Dionisio merged 4 commits intomasterfrom Jan 5, 2026
Merged
Conversation
Joao-Dionisio
commented
Dec 28, 2025
src/pyscipopt/scip.pyi
Outdated
| primal_bound: float = None | ||
| dual_bound: float = None | ||
| gap: float = None | ||
| primal_dual_integral: float = None |
Member
Author
There was a problem hiding this comment.
It has some problems with this statistics class, but this is going to be deprecated in favor of the JSON statistics
Contributor
jonathanberthias
left a comment
jonathanberthias
left a comment
There was a problem hiding this comment.
This is a great script, I'm surprised at how effective it is at reproducing the current stubs!
However, I do think it is overfitting the current state and will break as soon as we start improving the stubs as it will try to revert any changes we make.
Member
Author
|
removed the clique stuff, the tests weren't wroking and this is more important. The tests should be easier to add once #1076 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jonathanberthias when you have the time, can you please take a look? I deleted
scip.pyiand ran the script, generating thescip.pyithat's in this PR.I also wrapped
SCIPaddClique, and re-ran the script. It did add the stub toscip.pyi.